Searching for allowed carriers incorrectly uses magento_picking_id instead of magento_order_id

[Brendan Clune (Logic Supply)]

Lines 83-92 in stock_tracking.py:

magento_picking_id = picking.magento_id
if magento_picking_id is None:
    raise NoExternalId("No value found for the picking ID on "
                       "Magento side, the job will be retried later.")

self._validate(picking)
self._check_allowed_carrier(picking, magento_picking_id)
tracking_args = self._get_tracking_args(picking)
self.backend_adapter.add_tracking_number(magento_picking_id,
                                         *tracking_args)

The call to _check_allowed_carrier hits the getCarriers API endpoint in Magento, which expects the increment id of the magento sale, rather than the delivery object. The add_tracking_number call seems correct in this case.

[Brendan Clune (Logic Supply) (brendan-clune)]

For clarification, here is the Magento API call:

 public function getCarriers($orderIncrementId)
    {
        $order = Mage::getModel('sales/order')->loadByIncrementId($orderIncrementId);
    ...

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks for the report, you are right.
I linked a proposal.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Fix released en 2.2.1