commit bb19b18a71528579d972ab4c719a1ecf7bb2b48d
Author: Anda Nicolae <email address hidden>
Date: Fri May 11 10:51:56 2018 +0300
Coverity issues in contrail-controller/multicast/grpmgmt
I have run Coverity on branch R5.0 and it reported the
following issues in contrail-controller/multicast/grpmgmt:
- leaked_storage: Variable cat_entry going out of scope leaks
the storage it points to in
gmp_addrlist.c:gmp_lookup_create_addr_cat_entry()
Indeed, cat_entry should be freed if the following condition is matched:
if (cat_entry->adcat_ent_ord == ORD_BAD_ORDINAL)
- leaked_storage: Variable addr_thread going out of scope leaks
the storage it points to in
igmp_protocol.c:igmp_parse_v3_report_packet()
Indeed, addr_thread should be freed if the following condition is matched:
if (gmp_enqueue_addr_thread_addr(addr_thread, addr_ptr, IPV4_ADDR_LEN) < 0)
Change-Id: I04cf563b5b831bf72b11cba7a2df0d9d23da56ec
Closes-Bug: #1770578
Signed-off-by: Anda Nicolae <email address hidden>
Reviewed: https:/ /review. opencontrail. org/43023 github. com/Juniper/ contrail- controller/ commit/ bb19b18a7152857 9d972ab4c719a1e cf7bb2b48d
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit bb19b18a7152857 9d972ab4c719a1e cf7bb2b48d
Author: Anda Nicolae <email address hidden>
Date: Fri May 11 10:51:56 2018 +0300
Coverity issues in contrail- controller/ multicast/ grpmgmt
I have run Coverity on branch R5.0 and it reported the controller/ multicast/ grpmgmt:
following issues in contrail-
- leaked_storage: Variable cat_entry going out of scope leaks c:gmp_lookup_ create_ addr_cat_ entry() >adcat_ ent_ord == ORD_BAD_ORDINAL)
the storage it points to in
gmp_addrlist.
Indeed, cat_entry should be freed if the following condition is matched:
if (cat_entry-
- leaked_storage: Variable addr_thread going out of scope leaks c:igmp_ parse_v3_ report_ packet( ) addr_thread_ addr(addr_ thread, addr_ptr, IPV4_ADDR_LEN) < 0)
the storage it points to in
igmp_protocol.
Indeed, addr_thread should be freed if the following condition is matched:
if (gmp_enqueue_
Change-Id: I04cf563b5b831b f72b11cba7a2df0 d9d23da56ec
Closes-Bug: #1770578
Signed-off-by: Anda Nicolae <email address hidden>