commit 32e41ccb418e8bcd9c50420c48cd052a65a89f23
Author: Anda Nicolae <email address hidden>
Date: Wed May 9 18:54:33 2018 +0300
Coverity issues in contrail-controller/agent
- leaked_storage: Variable key going out of scope leaks the storage
it points to in vm_interface_config.cc:VmiProcessConfig
Must free key and data if data->device_type_ is
VmInterface::REMOTE_VM_VLAN_ON_VMI.
- leaked_storage: Variable pkt_handler going out of scope leaks the
storage it points to in segment_health_check.cc:SendRequest
Must free pkt_handler if service_mode is VmInterface::SERVICE_MODE_ERROR.
- bad_memset: Function memset with fill value '0' (the zero character)
in bgp_as_service.cc:BingBgpAsAServicePorts.cc
Correct is 0 instead of '0'.
- leaked_storage: Variable data going out of scope leaks the storage it
points to in nexthop_client.cc:WriteMessage
Actually, data is freed, but it needs to be freed by calling delete [] data
instead of free(data), because it was previsouly allocated by calling new[].
Change-Id: Ibbb94df3ac0fa4ef41789137aed4dc15fa4b3e84
Closes-Bug: #1770193
Signed-off-by: Anda Nicolae <email address hidden>
Reviewed: https:/ /review. opencontrail. org/42907 github. com/Juniper/ contrail- controller/ commit/ 32e41ccb418e8bc d9c50420c48cd05 2a65a89f23
Committed: http://
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master
commit 32e41ccb418e8bc d9c50420c48cd05 2a65a89f23
Author: Anda Nicolae <email address hidden>
Date: Wed May 9 18:54:33 2018 +0300
Coverity issues in contrail- controller/ agent
- leaked_storage: Variable key going out of scope leaks the storage config. cc:VmiProcessCo nfig :REMOTE_ VM_VLAN_ ON_VMI. health_ check.cc: SendRequest :SERVICE_ MODE_ERROR. service. cc:BingBgpAsASe rvicePorts. cc client. cc:WriteMessage
it points to in vm_interface_
Must free key and data if data->device_type_ is
VmInterface:
- leaked_storage: Variable pkt_handler going out of scope leaks the
storage it points to in segment_
Must free pkt_handler if service_mode is VmInterface:
- bad_memset: Function memset with fill value '0' (the zero character)
in bgp_as_
Correct is 0 instead of '0'.
- leaked_storage: Variable data going out of scope leaks the storage it
points to in nexthop_
Actually, data is freed, but it needs to be freed by calling delete [] data
instead of free(data), because it was previsouly allocated by calling new[].
Change-Id: Ibbb94df3ac0fa4 ef41789137aed4d c15fa4b3e84
Closes-Bug: #1770193
Signed-off-by: Anda Nicolae <email address hidden>