OpenContrail

  1. Bug #1770158
  2. Comment #10

Comment 10 for bug 1770158

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/43016
Committed: http://github.com/Juniper/contrail-controller/commit/2147207b81ea031bc7c3c6fe21b33a0d27fb6b45
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2147207b81ea031bc7c3c6fe21b33a0d27fb6b45
Author: Anda Nicolae <email address hidden>
Date: Wed May 9 15:45:19 2018 +0300

Coverity issues in contrail-controller/cfg_mirror.cc

I have run Coverity on branch R5.0 and it reported the following issues
in contrail-controller/cfg_mirror.cc:
- Variable entry going out of scope leaks the storage it points to in
cfg_mirror.cc:MirrorCfgTable::Add
- Variable entry going out of scope leaks the storage it points to in
cfg_mirror.cc:IntfMirrorCfgTable::Add

Indeed, in both functions listed above, variable entry is not freed on
else branch.

Change-Id: Ia083a3976bd1259e415195ae916a8dd377d50ffc
Closes-Bug: #1770158
Signed-off-by: Anda Nicolae <email address hidden>