commit 5fa48552c075a2323177e2d497849946fb06c4f7
Author: Andrei Bunghez <email address hidden>
Date: Mon Dec 4 16:55:30 2017 +0200
Several coverity issues in vrouter utilities
vif.c:
Initializing ret variable in vr_intf_op.
udp_util.c:
Using udp_free_client instead of udp_free, so that cl is freed as well.
nl_util.c:
Initializing attr in nl_dcb_parse_reply to DCB_ATTR_UNDEFINED.
Using nl_free_client to also free cl in nl_register_client. Otherwise, fields are freed but not the structure itself.
ini_parser.c:
Closing file before returning from parse_ini_file if ini_data allocation fails.
flow.c:
In flow_set_ip, updating match_string only if token is not null and token_length is assigned to and makes sense.
Initializing ret with 0 in flow_set_ip. It would be used uninitialized in the context of token being null.
In flow_set_match, updating match_string only if token is not null and token_length is assigned to and makes sense.
Reviewed: https:/ /review. opencontrail. org/38102 github. com/Juniper/ contrail- vrouter/ commit/ 5fa48552c075a23 23177e2d4978499 46fb06c4f7
Committed: http://
Submitter: Zuul (<email address hidden>)
Branch: R3.2
commit 5fa48552c075a23 23177e2d4978499 46fb06c4f7
Author: Andrei Bunghez <email address hidden>
Date: Mon Dec 4 16:55:30 2017 +0200
Several coverity issues in vrouter utilities
vif.c:
Initializing ret variable in vr_intf_op.
udp_util.c:
Using udp_free_client instead of udp_free, so that cl is freed as well.
nl_util.c:
Initializing attr in nl_dcb_parse_reply to DCB_ATTR_UNDEFINED.
Using nl_free_client to also free cl in nl_register_client. Otherwise, fields are freed but not the structure itself.
ini_parser.c:
Closing file before returning from parse_ini_file if ini_data allocation fails.
flow.c:
In flow_set_ip, updating match_string only if token is not null and token_length is assigned to and makes sense.
Initializing ret with 0 in flow_set_ip. It would be used uninitialized in the context of token being null.
In flow_set_match, updating match_string only if token is not null and token_length is assigned to and makes sense.
Change-Id: I04fbb636497f08 3099375c643d32a 8997d0a4c0d
Closes-Bug: #1736160