Comment 11 for bug 2036406

Revision history for this message
Dave Jones (waveform) wrote :

Trying to channel the SRU team, a couple of things I'd point out that may need some clarification in the bug description:

* Does this also need back-porting to lunar? We shouldn't have a situation where something is fixed in jammy but regresses for people upgrading to lunar (ignore this if these changes are already present in the lunar version)

* The Impact specifies what the bug is doing but not really what the "impact" actually is. What will it mean for users if this bug is *not* fixed? It may also be useful to describe precisely what firmware we're talking about (typically most firmware comes from the linux-firmware package but I'm guessing we're talking about early-boot related firmware here).

* In the Test Case is there enough information for people other than the reporter to test the fix?

* In the regression potential: as I understand it from the patches, there's *some* mkeficapsule code already in the jammy version but it's not built as part of u-boot-tools. Is that mkeficapsule code solely used by the mkeficapsule binary, or does patching it affect anything else in u-boot (i.e. does anything else pull in any parts of mkeficapsule)? If not, it's probably worth mentioning that mkeficapsule is "standalone" and these patches affect nothing other than a binary that isn't currently built in the jammy version.