Comment 12 for bug 2035561

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Hi binli, I hope this finds you well.

A few review points for your patch:
 - The version should be 0.43-1ubuntu1.1, not 0.43-1ubuntu2. See this page[1] for more information on SRU (and security update) versioning.
 - Most sponsors (in my experience) prefer DEP-3 headers[2]. It's not a hard blocker, but I would really like to see that.

Could you also expand a little further on the SRU template, specifically the regression potential, citing specific examples? The more (useful) information there, the better.

Please re-subscribe ubuntu-sponsors once you're able to follow up. Thanks for your work.

[1] https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging #2
[2] https://dep-team.pages.debian.net/deps/dep3/ (or remove the header, push the patch to the top of the stack, and run `quilt header --dep3 -e`)