Comment 27 for bug 1946096

Before I was relying on the information presented here and the changelog in the upload to consider regression risk. Today I reviewed the patches in more detail expecting to find what has been described. What's going on in 01_modem-quectel.patch? This says "add support for EM120/160 PCIe modules" and it seems to be adding support for a PCIe variant of a modem in the code that already supports a USB variant. But your changelog just says "Support manual firmware upgrading" with no mention of support for additional modems. Are you actually additionally adding support for this modem hardware where support didn't exist previously? I see no mention of additional additional modem support anywhere in this bug so far.

If so, then will you be able to test the regular functionality of these modems - both USB and PCIe - during SRU verification please? Do you have these two modems available? This would be to ensure that 1) the changes to modemmanager that relate to the USB variant haven't regressed; and 2) the changes to add support for the PCIe variant is actually working. If you can do this, then please add this to the Test Plan. If not, then further discussion is needed.

It looks like Impish no longer carries this patch as 1.16.6-2ubuntu1 was removed, so we also need an upload of this to Impish please.