Comment 10 for bug 1946096
Revision history for this message
| Robie Basak (racb) wrote Re: Apply upstream patches to fix problems for Foxconn and Quectel modems. | #10 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
SRU review
I don't see any explanation of what this is fixing, or why this is needed, so cannot review if the proposed changes qualify for an SRU under Ubuntu's policies.
Specifically I need an explanation of actual user impact, not just "fix some problems". Further, note that the procedure says "Do not create a meta-bug with a title like "Please SRU this" rather than using existing bug reports". We need actual public bugs for each of the specific problems that you're fixing. Each of those bugs should be linked from the changelog, so we can ensure during SRU verification that each of those issues have individually been verified fixed. Done properly, there is then no need for a meta bug like this one.
See https:/
The Focal upload is also missing a proper bug reference - the reference given doesn't match the standard pattern so didn't get copied to the Launchpad-
I'm rejecting both the Hirsute and Focal uploads since both uploads need their changelogs fixing to properly reference public bugs that contain full SRU information.