Comment 12 for bug 686731

Revision history for this message
Marius Gedminas (mgedmin) wrote :

I'm -0 for rebuilding them: this would result in the figures in /usr/share being different from the ones on the project website for the same version. 'make test' is sufficient to show the generation will work -- it performs the same thing as 'make images', but in a temporary directory that's cleaned up at the end.

I'd change my opinion to +1 if the images didn't change after every rebuild. This seems non-trivial; I'd probably need a registry of custom functions to replace repr() in order to avoid memory addresses of things like DocTestRunner instances appearing in the rendered image. Or I could hardcode them all with a series of ifs in my short_repr, but I already feel like I have enough special saces there. Hm. This bears more thinking about.

(I assume you're familiar with the numerical expressions of approval used in the Python community: -0 means neutrality, with a slight bias against the change; +1 means agreement.)