Nux

No glow: remove internal glow/shadow from Alt-tab switcher border and <Super> shortcut window

Bug #940493 reported by Paul Sladen on 2012-02-24
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nux
Fix Released
Undecided
Unassigned
Unity
Fix Released
Low
Andrea Cimitan
nux (Ubuntu)
Undecided
Unassigned
unity (Ubuntu)
Undecided
Unassigned

Bug Description

Glow is being removed from the Unity interface. This includes the borders and glow about the Alt-tab and <Super> short-cut/help screens.

Related branches

Paul Sladen (sladen) wrote :

corner.png: (25x25)

Paul Sladen (sladen) wrote :

corner_left.png (25 x 2)

Paul Sladen (sladen) wrote :

corner_right.png (2 x 25)

Paul Sladen (sladen) wrote :

Relevant assets in the current code are:

  unity/plugins/unityshell/resources/switcher_corner.png (30x30)
  unity/plugins/unityshell/resources/switcher_left.png (30x40)
  unity/plugins/unityshell/resources/switcher_top.png (40x30)

Paul Sladen (sladen) wrote :

Proposed reconstructed replacement. This is extensively different to Rosie's original that it'll need revalidated as being correct.

Changed in unity:
assignee: nobody → Paul Sladen (sladen)
status: New → In Progress
importance: Undecided → Low
Paul Sladen (sladen) wrote :

Proposed reconstructed replacement. This is extensively different to Rosie's original, and rebuilt from the interpolated corner. It will need revalidating as being correct.

Paul Sladen (sladen) wrote :

Ditto for this one.

Paul Sladen (sladen) wrote :

Screenshot with output per branch revision r2019.

Paul Sladen (sladen) wrote :

Fresh from Rosie for cutting.

Omer Akram (om26er) on 2012-03-01
Changed in unity:
milestone: none → 5.6.0
Paul Sladen (sladen) wrote :

The replacement is done, but I'd prefer to retest it first again, and Unity 3D trunk was refusing to build for the moment.

Andrea Cimitan (cimi) wrote :

update the assets paul, otherwise I have them here :-)

Paul Sladen (sladen) wrote :

After some further debugging with Cimi, the inside corners are not the problem with the assets, but from hardcoding of the corner radius with:

  nux::eSHAPE_CORNER_ROUND4,

which is causing the non-aligned overlap. There are a number of hard-coded options available in:

  /usr/include/Nux-2.0/Nux/Theme.h

thusly:

  enum UXStyleImageRef
  {
    …
    eSHAPE_CORNER_SQUARE,
    eSHAPE_CORNER_ROUND1,
    eSHAPE_CORNER_ROUND2,
    eSHAPE_CORNER_ROUND4,
    eSHAPE_CORNER_ROUND10,
    …
  }

But no ROUND6. This should need adding in:

  nux/data/UITextures/Painter.xml

along with a corresponding supporting texture entry in:

  nux/data/UITextures/RoundCorner_6pxrad.tga

Andrea Cimitan (cimi) wrote :

Correct ^^

tags: added: unity3
tags: added: unity3p
removed: unity3
Paul Sladen (sladen) wrote :

Rosie notes inside radius 5, outside radius 10.

Jason Smith (jassmith) wrote :

We should modify the painter to support arbitrary textures into the corner rounding function. This would solve this problem for all forseeable changes in the future.

Paul Sladen (sladen) wrote :

Current plan of action appears to be to add a new call eg. PaintShapeCornerTextureROP().

At our end, we just need to make a new TGA corner texture (based on 'nux/data/UITextures/RoundCorner_NNpxrad.tga') and supply that at the point of use.

Paul Sladen (sladen) wrote :

Five pixel radius.

Paul Sladen (sladen) wrote :

Six pixel radius.

Didier Roche (didrocks) on 2012-03-12
Changed in unity:
milestone: 5.6.0 → 5.8.0
Andrea Cimitan (cimi) on 2012-03-16
Changed in unity:
assignee: Paul Sladen (sladen) → Andrea Cimitan (cimi)
Changed in nux:
status: New → Fix Committed
Changed in unity:
status: In Progress → Fix Committed
Didier Roche (didrocks) on 2012-03-23
Changed in nux:
status: Fix Committed → Fix Released
Changed in unity:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nux - 2.8.0-0ubuntu1

---------------
nux (2.8.0-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - No glow: remove internal glow/shadow from Alt-tab switcher border and
      <Super> shortcut window (LP: #940493)
    - As soon as you start to drag a dash icon, the icon is drawn for a moment
      at (100, 100) (LP: #947362)
    - Unity launches selected application on commit pre-edit texts with ibus
      (LP: #954901)
 -- Didier Roche <email address hidden> Fri, 23 Mar 2012 14:47:36 +0100

Changed in nux (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers