Nux

Comment 6 for bug 1052765

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

SRU-able means that a bug can be included in an SRU. And commits that can be included in an SRU have to be either bug fixes (crashers) or really important feature improvements. If this is indeed a potential crasher fix, then we should change the bug title to indicate so, so that no one mistakes it for something not really fitting and SRU. Also, the trunk commit was really really large, including a lot of refactoring, which is also not really SRU material. If the fix that's worth backporting a one-liner as noted in the comment, then maybe this can be considered an SRU bug worth including in 3.0 - if it indeed would prevent a core dump.
And we need to ensure that no commits that are unnecessary land in the SRU branches - otherwise package uploads will be rejected, as what happened 2 times in the course of 2 weeks.

We also didn't notice a core dump with this code before, even though this particular faulty line is in nux since revision 513, which is one year old already. It's a VERY long time.

There was also no merge request already prepared, so I was only basing my opinions on the 4.0 fix - which is a big refactoring merge request that would rather get rejected by distro. So, if you think this fix is important, the crash probable and change small, then feel free to submit a merge request. We can always switch the bug back from 'Won't Fix' to 'Fix Committed' with no problem.