Comment 56 for bug 1057981

Revision history for this message
Jv (jv-ravichandran) wrote : Re: [Bug 1057981] Re: C#5 async tests are not supported
  • theTests.txt Edit (984 bytes, text/plain; charset=US-ASCII; name="theTests.txt")
  • cut.txt Edit (1.1 KiB, text/plain; charset=US-ASCII; name="cut.txt")

Hi Charlie,

The bug that I have highlighted is *a bug in code (reproduced)* not a bug
in NUnit. If it were a bug in NUnit obviously it would have passed.

>> 1) Tell us what version of NUnit you used to reproduce it. - The fixed
branch (although explained above)

It is not a bug in NUnit; it is a bug in code that I reproduced to simulate
the "pre-bug fix" scenario of a test passing regardless.

>>2) If possible, please provide a test case (in text form, not a
picture)that will reproduce the bug.

Attached is the code & test. The attached code and tests also demonstrates,
through the "taskId", that both the tasks are independent of each other and
provides the mechanism to test it, too!

>> 3) Tell us what you think NUnit should do instead of what it's doing.

I hope my "buggy "code/test helps. :) The intent was to test asynchronicity
in tests and have the mechanism to test it. The taskIds and the failing
tests prove that NUnit is functioning correctly despite the buggy code.

Jv

On Sun, Oct 7, 2012 at 9:12 AM, Charlie Poole <email address hidden> wrote:

> At first glance, this seems to be an error in the test, not a bug
> in nunit. But if you think it's a bug, please provide some more
> information...
>
> 1) Tell us what version of NUnit you used to reproduce it.
>
> 2) If possible, please provide a test case (in text form, not a picture)
> that will reproduce the bug.
>
> 3) Tell us what you think NUnit should do instead of what it's doing.
>
> charlie
>
> --
> You received this bug notification because you are a member of NUnit
> Developers, which is subscribed to NUnit V2.
> https://bugs.launchpad.net/bugs/1057981
>
> Title:
> C#5 async tests are not supported
>
> Status in NUnit Test Framework:
> Triaged
> Status in NUnitLite Testing Framework:
> Triaged
> Status in NUnit V2 Test Framework:
> Fix Committed
>
> Bug description:
> If a method is marked async, nunit does not recognise it as a test,
> and some test runners may incorrectly pass it while it is still
> running. These methods actually return a Task not void, and the test
> can only be passed if the task completes without a failure.
>
> As detailed here http://anthonysteele.co.uk/async-and-await-with-nunit
>
> MSTest supports async tests
>
> http://blogs.msdn.com/b/visualstudioalm/archive/2012/03/13/what-s-new-for-mstest-unit-tests-in-visual-studio-11-beta.aspx
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nunit-3.0/+bug/1057981/+subscriptions
>

--
Regards,

Ravichandran Jv
http://ravichandranjv.blogspot.com