commit a9650b3cbfc674e283964090fb64ac6297be5b78
Author: Matt Riedemann <email address hidden>
Date: Thu Nov 14 14:19:26 2019 -0500
Block deleting compute services with in-progress migrations
This builds on I0bd63b655ad3d3d39af8d15c781ce0a45efc8e3a
which made DELETE /os-services/{service_id} fail with a 409
response if the host has instances on it. This change checks
for in-progress migrations involving the nodes on the host,
either as the source or destination nodes, and returns a 409
error response if any are found.
Failling to do this can lead to orphaned resource providers
in placement and also failing to properly confirm or revert
a pending resize or cold migration.
A release note is included for the (justified) behavior
change in the API. A new microversion should not be required
for this since admins should not have to opt out of broken
behavior.
Reviewed: https:/ /review. opendev. org/694546 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=a9650b3cbfc 674e283964090fb 64ac6297be5b78
Committed: https:/
Submitter: Zuul
Branch: stable/train
commit a9650b3cbfc674e 283964090fb64ac 6297be5b78
Author: Matt Riedemann <email address hidden>
Date: Thu Nov 14 14:19:26 2019 -0500
Block deleting compute services with in-progress migrations
This builds on I0bd63b655ad3d3 d39af8d15c781ce 0a45efc8e3a {service_ id} fail with a 409
which made DELETE /os-services/
response if the host has instances on it. This change checks
for in-progress migrations involving the nodes on the host,
either as the source or destination nodes, and returns a 409
error response if any are found.
Failling to do this can lead to orphaned resource providers
in placement and also failing to properly confirm or revert
a pending resize or cold migration.
A release note is included for the (justified) behavior
change in the API. A new microversion should not be required
for this since admins should not have to opt out of broken
behavior.
Conflicts:
nova/ tests/functiona l/integrated_ helpers. py
NOTE(mriedem): The conflict is due to change e06924def814a3a 6e09ceb91a15894 which is not in Train.
Iec61f56c05
NOTE(mriedem): services.py had to be updated to add the LOG 4a546ae5f26bb9b a19318ece6a
variable since change I8403a841f21a62
is not in Train.
Change-Id: I70e06c607045a1 c0842f13069e51f ef438012a9c a2a76ea09204a4b a24c21e191)
Closes-Bug: #1852610
(cherry picked from commit 92fed026103b47f