Comment 3 for bug 1852465

Reviewed: https://review.opendev.org/694179
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=36b110dfc5f8f04234b189a50e96de8dde5f3471
Submitter: Zuul
Branch: master

commit 36b110dfc5f8f04234b189a50e96de8dde5f3471
Author: Matt Riedemann <email address hidden>
Date: Wed Nov 13 18:27:36 2019 -0500

    Do not reschedule on ExternalNetworkAttachForbidden

    When creating a server, if network setup fails with
    ExternalNetworkAttachForbidden then we should abort
    the build rather than reschedule because it's not
    going to work on another host either.

    A functional test is added for this since it's hard
    to reason about whether or not it works properly
    due to the async nature of network setup during
    server create and the _build_resources context
    manager. It's probably not a bad idea to have a
    functional test for a scenario that uses external
    networks either (and we can build on this).

    Change-Id: I6dd5b3f75e2746f53f9758f1a186794a98dba9bf
    Closes-Bug: #1852465