I think we can make a couple of simple enhancements by:
1. only join on security_groups if using nova-network
2. only join on system_metadata if using dynamic vendordata providers
Backporting the system_metadata change would be tricky though since we did use system_metadata to perform an online data migration for at least the instance.flavor information. Having said that, we removed that system_metadata <> flavor migration code in Rocky:
I think we can make a couple of simple enhancements by:
1. only join on security_groups if using nova-network
2. only join on system_metadata if using dynamic vendordata providers
Backporting the system_metadata change would be tricky though since we did use system_metadata to perform an online data migration for at least the instance.flavor information. Having said that, we removed that system_metadata <> flavor migration code in Rocky:
https:/ /review. openstack. org/#/c/ 508357/
And as that commit message says, you couldn't upgrade to Liberty if you hadn't migrated the flavor data:
https:/ /review. openstack. org/#/c/ 174480/
So maybe it's OK to at least backport this metadata-api join improvement to at least Pike.