Comment 18 for bug 1837955

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.opendev.org/673576
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3ec4c5ed9c93ee261a948db9679d1550f58c2882
Submitter: Zuul
Branch: stable/queens

commit 3ec4c5ed9c93ee261a948db9679d1550f58c2882
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Thu Jul 25 20:19:40 2019 -0700

    Cleanup when hitting MaxRetriesExceeded from no host_available

    Prior to this patch there was a condition when no
    host_available was true and an exception would get
    raised without first cleaning up the instance.
    This causes instances to get indefinitely stuck in
    a scheduling state.

    This patch fixes this by calling the clean up function
    and then exits build_instances using a return statement.

    The related functional regression recreate test is updated
    to show this fixes the bug.

    Change-Id: I6a2c63a4c33e783100208fd3f45eb52aad49e3d6
    Closes-bug: #1837955
    (cherry picked from commit b98d4ba6d54f5ca2999a8fe6b6d7dfcc134061df)
    (cherry picked from commit fcc2b9e33ed2b3d9f469b458e0f46011fe9883ac)
    (cherry picked from commit e3b68a1c8bbedd877cfc988898f7e458ab067f28)