commit f50bd6e65758c7c3f3b433a1e66bd8c94f6947f8
Author: Stephen Finucane <email address hidden>
Date: Wed Jun 5 16:39:45 2019 +0100
Unplug VIFs as part of cleanup of networks
If an instance fails to build, which is possible for a variety of
reasons, we may end up in a situation where we have remnants of a
plugged VIF (typically files) left on the host. This is because we
cleanup from the neutron perspective but don't attempt to unplug the
VIF, a call which may have many side-effects depending on the VIF
driver. Resolve this by always attempting to unplug VIFs as part of the
network cleanup.
A now invalid note is also removed and a unit test corrected.
NOTE(stephenfin): Conflict is because we're missing change
Ic5cab99944df9e501ba2032eb96911c36304494d ("Port binding based on events
during live migration") which we don't want to backport.
Closes-Bug: #1831771
Related-Bug: #1830081
Signed-off-by: Stephen Finucane <email address hidden>
Change-Id: Ibdbde4ed460a99b0cbe0d6b76e0e5b3c0650f9d9
(cherry picked from commit b3e14931d6aac6ee5776ce1e6974c75a5a6b1823)
(cherry picked from commit 3e935325a88bf7a0206ec07bc67383e8be846f15)
(cherry picked from commit 265fd4f6bd56c711d7827c2defc993e19a541770)
(cherry picked from commit 85521691a843b9606d4a8aa050f4452ba025eb02)
Reviewed: https:/ /review. opendev. org/715406 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=f50bd6e6575 8c7c3f3b433a1e6 6bd8c94f6947f8
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit f50bd6e65758c7c 3f3b433a1e66bd8 c94f6947f8
Author: Stephen Finucane <email address hidden>
Date: Wed Jun 5 16:39:45 2019 +0100
Unplug VIFs as part of cleanup of networks
If an instance fails to build, which is possible for a variety of
reasons, we may end up in a situation where we have remnants of a
plugged VIF (typically files) left on the host. This is because we
cleanup from the neutron perspective but don't attempt to unplug the
VIF, a call which may have many side-effects depending on the VIF
driver. Resolve this by always attempting to unplug VIFs as part of the
network cleanup.
A now invalid note is also removed and a unit test corrected.
Conflicts: tests/unit/ compute/ test_compute_ mgr.py
nova/
NOTE( stephenfin) : Conflict is because we're missing change df9e501ba2032eb 96911c36304494d ("Port binding based on events
Ic5cab99944
during live migration") which we don't want to backport.
Closes-Bug: #1831771 b0cbe0d6b76e0e5 b3c0650f9d9 e5776ce1e6974c7 5a5a6b1823) 0206ec07bc67383 e8be846f15) 1d7827c2defc993 e19a541770) 06d4a8aa050f445 2ba025eb02)
Related-Bug: #1830081
Signed-off-by: Stephen Finucane <email address hidden>
Change-Id: Ibdbde4ed460a99
(cherry picked from commit b3e14931d6aac6e
(cherry picked from commit 3e935325a88bf7a
(cherry picked from commit 265fd4f6bd56c71
(cherry picked from commit 85521691a843b96