Starting in noVNC v1.1.0, the token query parameter is no longer
forwarded via cookie [1]. We must instead use the 'path' query
parameter to pass the token through to the websocketproxy [2].
This means that if someone deploys noVNC v1.1.0, VNC consoles will
break in nova because the code is relying on the cookie functionality
that v1.1.0 removed.
This modifies the ConsoleAuthToken.access_url property to include the
'path' query parameter as part of the returned access_url that the
client will use to call the console proxy service.
This change is backward compatible with noVNC < v1.1.0. The 'path' query
parameter is a long supported feature in noVNC.
Reviewed: https:/ /review. opendev. org/649372 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=9606c80402f 6db20d62b689c58 aa8f024183628a
Committed: https:/
Submitter: Zuul
Branch: master
commit 9606c80402f6db2 0d62b689c58aa8f 024183628a
Author: Mohammed Naser <email address hidden>
Date: Tue Apr 2 11:34:58 2019 -0400
Add 'path' query parameter to console access url
Starting in noVNC v1.1.0, the token query parameter is no longer
forwarded via cookie [1]. We must instead use the 'path' query
parameter to pass the token through to the websocketproxy [2].
This means that if someone deploys noVNC v1.1.0, VNC consoles will
break in nova because the code is relying on the cookie functionality
that v1.1.0 removed.
This modifies the ConsoleAuthToke n.access_ url property to include the
'path' query parameter as part of the returned access_url that the
client will use to call the console proxy service.
This change is backward compatible with noVNC < v1.1.0. The 'path' query
parameter is a long supported feature in noVNC.
Co-Authored-By: melanie witt <email address hidden>
Closes-Bug: #1822676
[1] https:/ /github. com/novnc/ noVNC/commit/ 51f9f0098d306bb c67cc8e02ae5479 21b6f6585c /github. com/novnc/ noVNC/pull/ 1220
[2] https:/
Change-Id: I2ddf0f4d768b69 8e980594dd67206 464a9cea37b