Comment 6 for bug 1816938

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/rocky)

Reviewed: https://review.openstack.org/647651
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8d757888a8179e5bfbdfee26eb672590f964f574
Submitter: Zuul
Branch: stable/rocky

commit 8d757888a8179e5bfbdfee26eb672590f964f574
Author: Takashi NATSUME <email address hidden>
Date: Sat Feb 23 00:56:23 2019 +0900

    Override the 'get' method in DriverBlockDevice class

    The following methods are overridden in DriverBlockDevice class.

    * __getattr__
    * __getitem__

    The 'get' method is not overridden.
    The value cannot be got by the 'get' method
    though the value can be got by '__getattr__' (e.g. bdm.volumd_id)
    or '__getitem__' (e.g. bdm['volume_id']) method.
    So override the 'get' method to fix the issue.

    Conflicts:
        nova/tests/unit/virt/test_block_device.py

        The conflict is due to not including
        Icc301230fe7c8e3ebbbcc7f4a807e562db7f93e3 in rocky.

    Change-Id: Ic665fc1956831110937d98553e526cb909e49997
    Closes-Bug: #1816938
    (cherry picked from commit 3c66b40dbd23e3f792a86da5a15c993c52c9b377)
    (cherry picked from commit ae40ceba8420b3b6c4bd8e29cf95ec21fd20e1e8)