Migrations use the libvirt driver's get_host_ip_addr() method to
determine the dest_host field of the migration object.
get_host_ip_addr() checks whether CONF.my_ip is actually assigned to
one of the host's interfaces. It does so by calling
get_machine_ips(), which iterates over all of the host's interfaces.
If the host has many interfaces, this can take a long time, and
introduces needless delays in processing the migration.
get_machine_ips() is only used to print a warning, so this patch moves
the get_machine_ips() call to a single method in init_host(). This
way, a warning is still emitted at compute service startup, and
migration progress is not needlessly slowed down.
NOTE(artom) While the following paragraph still applies, the poison
patch will not be backported. Stubbing out use of
netifaces.interfaces() is still a good thing to do, however.
This patch also has a chicken and egg problem with the patch on top of
it, which poisons use of netifaces.interfaces() in tests. While this
patch fixes all the tests that break with that poison, it starts
breaking different tests because of the move of get_machine_ips() into
init_host(). Therefore, while not directly related to the bug, this
patch also preventatively mocks or stubs out any use of
get_machine_ips() that will get poisoned with the subsequent patch.
Closes-bug: 1837075
Change-Id: I58a4038b04d5a9c28927d914e71609e4deea3d9f
(cherry picked from commit 30d8159d4ee51a26a03de1cb134ea64c6c07ffb2)
Reviewed: https:/ /review. opendev. org/672154 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=560317c766a fc4a4c4c5017ecf c9ce432fe63ea7
Committed: https:/
Submitter: Zuul
Branch: stable/stein
commit 560317c766afc4a 4c4c5017ecfc9ce 432fe63ea7
Author: Artom Lifshitz <email address hidden>
Date: Fri Jul 19 11:35:24 2019 -0400
libvirt: move checking CONF.my_ip to init_host()
Migrations use the libvirt driver's get_host_ip_addr() method to host_ip_ addr() checks whether CONF.my_ip is actually assigned to machine_ ips(), which iterates over all of the host's interfaces. machine_ ips() is only used to print a warning, so this patch moves
determine the dest_host field of the migration object.
get_
one of the host's interfaces. It does so by calling
get_
If the host has many interfaces, this can take a long time, and
introduces needless delays in processing the migration.
get_
the get_machine_ips() call to a single method in init_host(). This
way, a warning is still emitted at compute service startup, and
migration progress is not needlessly slowed down.
NOTE(artom) While the following paragraph still applies, the poison interfaces( ) is still a good thing to do, however.
patch will not be backported. Stubbing out use of
netifaces.
This patch also has a chicken and egg problem with the patch on top of interfaces( ) in tests. While this machine_ ips() that will get poisoned with the subsequent patch.
it, which poisons use of netifaces.
patch fixes all the tests that break with that poison, it starts
breaking different tests because of the move of get_machine_ips() into
init_host(). Therefore, while not directly related to the bug, this
patch also preventatively mocks or stubs out any use of
get_
Closes-bug: 1837075 c28927d914e7160 9e4deea3d9f 6a03de1cb134ea6 4c6c07ffb2)
Change-Id: I58a4038b04d5a9
(cherry picked from commit 30d8159d4ee51a2