This may lead to edge case, like in rescue where this value can be mistakenly
updated to reflect disk bus property of rescue image (hw_disk_bus).
Further more, a _get* method should not modify instance object.
Note that test test_get_guest_config_bug_1118829 is removed because no more
relevant with current code.
Change-Id: I1787f9717618d0837208844e8065840d30341cf7
Closes-Bug: #1835926
(cherry picked from commit 5e0ed5e7fee3c4c887263a0e9fa847c2dcc5cf3b)
(cherry picked from commit 5e858d0cbd672639318543201e251ed00324a9c2)
(cherry picked from commit 9f9f8d330a50aec188e55ab8ae921db710e6cc83)
Reviewed: https:/ /review. opendev. org/696353 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=c075e3a76d0 7b8d8ccf2017568 10567ddf04db60
Committed: https:/
Submitter: Zuul
Branch: stable/rocky
commit c075e3a76d07b8d 8ccf20175681056 7ddf04db60
Author: Alexandre Arents <email address hidden>
Date: Tue Jul 9 16:13:01 2019 +0000
Do not update root_device_name during guest config
_get_ guest_config( ) is currently updating instance. root_device_ name
and called in many ways like:
_hard_reboot(), rescue(), spawn(), resume(), finish_migration(), revert_ migration( )
finish_
It is an issue because root_device_name is initally set during instance
build and should remain the same after:
manager.py: _do_build_ and_run_ instance( )
_default_ block_device_ names() <-here
..
driver. spawn()
..
This may lead to edge case, like in rescue where this value can be mistakenly
updated to reflect disk bus property of rescue image (hw_disk_bus).
Further more, a _get* method should not modify instance object.
Note that test test_get_ guest_config_ bug_1118829 is removed because no more
relevant with current code.
Change-Id: I1787f9717618d0 837208844e80658 40d30341cf7 887263a0e9fa847 c2dcc5cf3b) 9318543201e251e d00324a9c2) 188e55ab8ae921d b710e6cc83)
Closes-Bug: #1835926
(cherry picked from commit 5e0ed5e7fee3c4c
(cherry picked from commit 5e858d0cbd67263
(cherry picked from commit 9f9f8d330a50aec