Comment 9 for bug 1682020

Reviewed: https://review.openstack.org/496605
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d983234288728427235ef2c1f355ec135119b865
Submitter: Jenkins
Branch: master

commit d983234288728427235ef2c1f355ec135119b865
Author: Stephen Finucane <email address hidden>
Date: Wed Aug 23 11:15:17 2017 +0100

    conf: Allow users to unset 'keymap' options

    Defining the 'keymap' option in libvirt results in the '-k' option being
    passed through to QEMU [1][2]. This QEMU option has some uses, primarily
    for users interacting with QEMU via stdin on the text console. However,
    for users interacting with QEMU via VNC or Spice, like nova users do, it
    is strongly recommended to never add the "-k" option. Doing so will
    force QEMU to do keymap conversions which are known to be lossy. This
    disproportionately affects users with non-US keyboard layouts, who would
    be better served by relying on the guest OS to manage this.

    In the long term, we would like to deprecate these options. However, we
    must do this in three parts. This part allows users to unset the options
    and warns users who have them set about the side effects. This change is
    intended to be backported. A future change will fully deprecate the
    options. Finally, after the deprecation cycle has passed, we can remove
    these options in their entirety.

    [1] https://github.com/libvirt/libvirt/blob/v1.2.9-maint/src/qemu/qemu_command.c#L6985-L6986
    [2] https://github.com/libvirt/libvirt/blob/v1.2.9-maint/src/qemu/qemu_command.c#L7215-L7216

    Change-Id: I6b1d719db0537b0f53768dbb00a5b4d01c85ba3a
    Related-Bug: #1682020