commit 239bdd0fd243a97f3cf36999f9dbdd99b6b4ab6a
Author: Sean Mooney <email address hidden>
Date: Wed Dec 19 19:40:05 2018 +0000
PCI: do not force remove allocated devices
In the ocata release the pci_passthrough_whitelist
was moved from the [DEFAULT] section of the nova.conf
to the [pci] section and renamed to passthrough_whitelist.
On upgrading if the operator chooses to migrate the config
value to the new section it is not uncommon
to forget to rename the config value.
Similarly if an operator is updateing the whitelist and
mistypes the value it can also lead to the whitelist
being ignored.
As a result of either error the nova compute agent
would delete all database entries for a host regardless of
if the pci device was in use by an instance. If this occurs
the only recorse for an operator is to delete and recreate
the guest on that host after correcting the error or manually
restore the database to backup or otherwise consistent state.
This change alters the _set_hvdevs function to not force
remove allocated or claimed devices if they are no longer
present in the pci whitelist.
Conflicts:
nova/pci/manager.py
Closes-Bug: #1633120
Change-Id: I6e871311a0fa10beaf601ca6912b4a33ba4094e0
(cherry picked from commit 26c41eccade6412f61f9a8721d853b545061adcc)
Reviewed: https:/ /review. openstack. org/635074 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=239bdd0fd24 3a97f3cf36999f9 dbdd99b6b4ab6a
Committed: https:/
Submitter: Zuul
Branch: stable/pike
commit 239bdd0fd243a97 f3cf36999f9dbdd 99b6b4ab6a
Author: Sean Mooney <email address hidden>
Date: Wed Dec 19 19:40:05 2018 +0000
PCI: do not force remove allocated devices
In the ocata release the pci_passthrough _whitelist whitelist.
was moved from the [DEFAULT] section of the nova.conf
to the [pci] section and renamed to passthrough_
On upgrading if the operator chooses to migrate the config
value to the new section it is not uncommon
to forget to rename the config value.
Similarly if an operator is updateing the whitelist and
mistypes the value it can also lead to the whitelist
being ignored.
As a result of either error the nova compute agent
would delete all database entries for a host regardless of
if the pci device was in use by an instance. If this occurs
the only recorse for an operator is to delete and recreate
the guest on that host after correcting the error or manually
restore the database to backup or otherwise consistent state.
This change alters the _set_hvdevs function to not force
remove allocated or claimed devices if they are no longer
present in the pci whitelist.
Conflicts: pci/manager. py
nova/
Closes-Bug: #1633120 beaf601ca6912b4 a33ba4094e0 f61f9a8721d853b 545061adcc)
Change-Id: I6e871311a0fa10
(cherry picked from commit 26c41eccade6412