As of change I6827137f35c0cb4f9fc4c6f753d9a035326ed01b in
Ocata, the ResourceTracker manages multiple compute nodes
via its "compute_nodes" variable, but the "stats" variable
was still being shared across all nodes, which leads to
leaking stats across nodes in an ironic deployment where
a single nova-compute service host is managing multiple
ironic instances (nodes).
This change makes ResourceTracker.stats node-specific
which fixes the ironic leak but also allows us to remove
the stats deepcopy while iterating over instances which
should improve performance for single-node deployments with
potentially a large number of instances, i.e. vCenter.
Conflicts: nova/compute/resource_tracker.py
NOTE(mriedem): The conflict is due to not having change
Ic5188d4c5a7e8aa4c79c37e63124fe3a305ef568 in Queens.
Reviewed: https:/ /review. openstack. org/587976 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=7d99f5753f9 92bd4b58b0aaa7f 83f71fb044776f
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit 7d99f5753f992bd 4b58b0aaa7f83f7 1fb044776f
Author: Matt Riedemann <email address hidden>
Date: Tue Jul 31 17:26:47 2018 -0400
Make ResourceTracker .stats node-specific
As of change I6827137f35c0cb 4f9fc4c6f753d9a 035326ed01b in
Ocata, the ResourceTracker manages multiple compute nodes
via its "compute_nodes" variable, but the "stats" variable
was still being shared across all nodes, which leads to
leaking stats across nodes in an ironic deployment where
a single nova-compute service host is managing multiple
ironic instances (nodes).
This change makes ResourceTracker .stats node-specific
which fixes the ironic leak but also allows us to remove
the stats deepcopy while iterating over instances which
should improve performance for single-node deployments with
potentially a large number of instances, i.e. vCenter.
Conflicts:
nova/ compute/ resource_ tracker. py
NOTE(mriedem): The conflict is due to not having change 7e8aa4c79c37e63 124fe3a305ef568 in Queens.
Ic5188d4c5a
Change-Id: I0b9e5b711878fa 47ba90e43c0b414 37b57cf8ef6 21cf954cd6b3463 c9fcc637e6)
Closes-Bug: #1784705
Closes-Bug: #1777422
(cherry picked from commit b5b7d86bb04f92d