Comment 12 for bug 1744325

Reviewed: https://review.openstack.org/536904
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=83fd8ac0bfd3d9e5dd4ad48bfcb845d80095b845
Submitter: Zuul
Branch: stable/ocata

commit 83fd8ac0bfd3d9e5dd4ad48bfcb845d80095b845
Author: int32bit <email address hidden>
Date: Mon Jan 22 17:05:53 2018 +0800

    Set server status to ERROR if rebuild failed

    Currently there is no indication that the rebuild was refused,
    and worse, we may have a wrong imageref for the instance.

    This patch set the instance to ERROR status if rebuild failed in the
    scheduling stage. The user can rebuild the instance with valid image
    to get it out of ERROR state and reset with right instance metadata and
    properties.

    Closes-Bug: 1744325

     Conflicts:
        nova/conductor/manager.py
        nova/tests/functional/regressions/test_bug_1713783.py
        nova/tests/functional/test_servers.py
        nova/tests/unit/conductor/test_conductor.py

    NOTE(melwitt): The conflicts were because of log translation, the fact
    that the regression test for bug 1713783 doesn't exist in Ocata, there
    are addtional rebuild functional tests in Pike that don't exist in
    Ocata, and the select_destinations method has additional parameters in
    Pike that don't exist in Ocata.

    Change-Id: Ibb7bee15a3d4ee6f0ef53ba12e8b41f65a1fe999
    (cherry picked from commit d03a890a34f632adc9a19a33c8a5aebbccec50e4)
    (cherry picked from commit 22a39b8f9b76d5f330a3f185e7d40f208a6a47f3)