Comment 9 for bug 1737856

Reviewed: https://review.openstack.org/530982
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=808d36475103e373f1deb3344b6829ce68d6cdd5
Submitter: Zuul
Branch: stable/newton

commit 808d36475103e373f1deb3344b6829ce68d6cdd5
Author: Matt Riedemann <email address hidden>
Date: Tue Dec 12 21:27:28 2017 -0500

    Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker

    For some reason, probably because build requests are meant to be short lived
    and we don't get a lot of bugs about paging misbehavior, when paging instances
    with a marker, we didn't raise MarkerNotFound if we didn't find the marker in
    the list of build requests. Doing so would match what we do when paging over
    cells and listing instances using a marker. Once we find the marker, be that
    in build_requests, or one of the cells, we need to set the marker to None to
    stop looking for it elsewhere if we have more space to fill our limit.

    For example, see change I8a957bebfcecd6ac712103c346e028d80f1ecd7c.

    This patch fixes the issue by raising MarkerNotFound from BuildRequestList
    get_by_filters if there is a marker and we didn't find a build request for
    it. The compute API get_all() method handles that as normal and continues
    looking for the marker in one of the cells.

    Change-Id: I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab
    Closes-Bug: #1737856
    (cherry picked from commit 1706e3989157f912bce99beb99c75216a064eb2d)
    (cherry picked from commit 344029b94ad7ff4667403a851d33c3ddb4e97b4b)
    (cherry picked from commit b00b2fe9be4394e7c9cf73c168d435a2333d12f6)