commit 344029b94ad7ff4667403a851d33c3ddb4e97b4b
Author: Matt Riedemann <email address hidden>
Date: Tue Dec 12 21:27:28 2017 -0500
Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker
For some reason, probably because build requests are meant to be short lived
and we don't get a lot of bugs about paging misbehavior, when paging instances
with a marker, we didn't raise MarkerNotFound if we didn't find the marker in
the list of build requests. Doing so would match what we do when paging over
cells and listing instances using a marker. Once we find the marker, be that
in build_requests, or one of the cells, we need to set the marker to None to
stop looking for it elsewhere if we have more space to fill our limit.
For example, see change I8a957bebfcecd6ac712103c346e028d80f1ecd7c.
This patch fixes the issue by raising MarkerNotFound from BuildRequestList
get_by_filters if there is a marker and we didn't find a build request for
it. The compute API get_all() method handles that as normal and continues
looking for the marker in one of the cells.
Reviewed: https:/ /review. openstack. org/530980 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=344029b94ad 7ff4667403a851d 33c3ddb4e97b4b
Committed: https:/
Submitter: Zuul
Branch: stable/pike
commit 344029b94ad7ff4 667403a851d33c3 ddb4e97b4b
Author: Matt Riedemann <email address hidden>
Date: Tue Dec 12 21:27:28 2017 -0500
Raise MarkerNotFound if BuildRequestLis t.get_by_ filters doesn't find marker
For some reason, probably because build requests are meant to be short lived
and we don't get a lot of bugs about paging misbehavior, when paging instances
with a marker, we didn't raise MarkerNotFound if we didn't find the marker in
the list of build requests. Doing so would match what we do when paging over
cells and listing instances using a marker. Once we find the marker, be that
in build_requests, or one of the cells, we need to set the marker to None to
stop looking for it elsewhere if we have more space to fill our limit.
For example, see change I8a957bebfcecd6 ac712103c346e02 8d80f1ecd7c.
This patch fixes the issue by raising MarkerNotFound from BuildRequestList
get_by_filters if there is a marker and we didn't find a build request for
it. The compute API get_all() method handles that as normal and continues
looking for the marker in one of the cells.
Conflicts:
nova/ tests/unit/ compute/ test_compute_ api.py
NOTE(mriedem): The conflicts are due to not having 701c4cc782f31b9 e5917011123261 nor e0b0c6e80c1e3b2 f1b48fd2c8d1d9 in Pike.
3e37c2e10e1
d5244f2fae1
Change-Id: I1aa3ca6cc70cef 65d24dec1e7db94 91c9b73f7ab 2bce99beb99c752 16a064eb2d)
Closes-Bug: #1737856
(cherry picked from commit 1706e3989157f91