commit 17b9b900a249f6f432552fe27a9cdd54c1495b99
Author: Eric M Gonzalez <email address hidden>
Date: Mon Nov 13 14:02:27 2017 -0600
unquiesce instance on volume snapshot failure
This patch adds an exception catch to "snapshot_volume_backed()" of
compute/api.py that catches (at the moment) _all_ exceptions from the
underlying cinderclient. Previously, if the instance is quiesced ( frozen
filesystem ) then the exception will break execution of the function,
skipping the needed unquiesce, and leave the instance in a frozen state.
Now, the exception catch will unquiesce the instance if it was prior to
the failure.
Got a unit test in place with the help of Matt Riedemann. test_snapshot_volume_backed_with_quiesce_create_snap_fails
Reviewed: https:/ /review. openstack. org/545966 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=17b9b900a24 9f6f432552fe27a 9cdd54c1495b99
Committed: https:/
Submitter: Zuul
Branch: stable/pike
commit 17b9b900a249f6f 432552fe27a9cdd 54c1495b99
Author: Eric M Gonzalez <email address hidden>
Date: Mon Nov 13 14:02:27 2017 -0600
unquiesce instance on volume snapshot failure
This patch adds an exception catch to "snapshot_ volume_ backed( )" of
compute/api.py that catches (at the moment) _all_ exceptions from the
underlying cinderclient. Previously, if the instance is quiesced ( frozen
filesystem ) then the exception will break execution of the function,
skipping the needed unquiesce, and leave the instance in a frozen state.
Now, the exception catch will unquiesce the instance if it was prior to
the failure.
Got a unit test in place with the help of Matt Riedemann.
test_snapshot_ volume_ backed_ with_quiesce_ create_ snap_fails
Conflicts:
nova/ compute/ api.py
nova/ tests/unit/ compute/ test_compute_ api.py
NOTE(mriedem): The conflicts are due to not having change c67543f27a6c87c 57b47501fff38c2 in Pike.
I9ce48e768c
Change-Id: I60de179c72eede 6746696f29462ee 9d805dace47 051348a3ace832b e8151299a7) 3bd209e714cd0aa 60b3a31d48)
Closes-bug: #1731986
(cherry picked from commit bca425a33f52584
(cherry picked from commit 7ab98b5345f4a02