Comment 6 for bug 1616938

Revision history for this message
Nikhil Komawar (nikhil-komawar) wrote :

This issue seems to be happening much before the code block reaches the xen driver at the (nova.image.glance), so the schema check needs to be added here too https://github.com/openstack/nova/blob/65b72f2d9d829fa6e0f8ed7bea2fb2831d9ebb8b/nova/image/glance.py#L651 (this schema validation is new in v2, so a v2 issue here)

besides above:

It's not a glance issue (as per current description) so I marked it incomplete but if more issues are found we can discuss.

From the current looks of it, the assumptions during v1->v2 port was that xen was being sparsely deployed and they went with what made sense to pass the gate tests.

So, I think the first thing reporter needs to do is add a test in the gate to indicate this use case. (This will avoid regressions)

Then to solve this we can add that check which fetches the schema from glance-api, checks if the format attempted to upload is correct and logs appropriate message if failed. (at the xen plugin, we can't reuse the code that will be added as prescribed above)

Also, I checked the nova xen driver and looks like it is supported for vhd only for both v1 and v2

https://github.com/openstack/nova/blob/15a159b3fcedc1b360367641a41413966c854a9a/plugins/xenserver/xenapi/etc/xapi.d/plugins/glance.py#L251

https://github.com/openstack/nova/blob/15a159b3fcedc1b360367641a41413966c854a9a/plugins/xenserver/xenapi/etc/xapi.d/plugins/glance.py#L316