disassociate_floating_ip with multi_host=True fails

[Brian Waldon]

When calling disassociate_floating_ip in an environment using multi_host, I see a 401 returned through the Nova API and the following log in the nova-network log:

2012-11-02 17:41:30 ERROR nova.openstack.common.rpc.amqp [-] Exception during message handling
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp Traceback (most recent call last):
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/amqp.py", line 275, in _process_data
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/nova/openstack/common/rpc/dispatcher.py", line 145, in dispatch
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp return getattr(proxyobj, method)(ctxt, **kwargs)
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/nova/network/manager.py", line 266, in wrapped
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp return func(self, context, *args, **kwargs)
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/nova/network/manager.py", line 612, in disassociate_floating_ip
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp context, instance['host'], 'network')
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/nova/db/api.py", line 128, in service_get_by_host_and_topic
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp return IMPL.service_get_by_host_and_topic(context, host, topic)
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/nova/db/sqlalchemy/api.py", line 110, in wrapper
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp raise exception.AdminRequired()
2012-11-02 17:41:30 TRACE nova.openstack.common.rpc.amqp AdminRequired: User does not have admin privileges

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/15287

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/15287
Committed: http://github.com/openstack/nova/commit/eedd98477dd3b8a5561d30732b7ccf71e9a7d428
Submitter: Jenkins
Branch: master

commit eedd98477dd3b8a5561d30732b7ccf71e9a7d428
Author: Brian Waldon <email address hidden>
Date: Fri Nov 2 10:47:34 2012 -0700

    Use elevated context in disassociate_floating_ip

    The call to service_get_by_host_and_topic would raise AdminRequired
    in the case that a non-admin tried to disassociate a floating ip
    from their instance and multi_host was on. Using an elevated
    context for the db lookup enables the host lookup to happend and
    allows a user to disassociate their floating ips.

    Fixes bug 1074437

    Change-Id: I3d47b5a48eae21ea913120bd00728a0b8132da81

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/17072

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/17072
Committed: http://github.com/openstack/nova/commit/3ede373f281edb07141b7e8752670c16878eb909
Submitter: Jenkins
Branch: stable/folsom

commit 3ede373f281edb07141b7e8752670c16878eb909
Author: Brian Waldon <email address hidden>
Date: Fri Nov 2 10:47:34 2012 -0700

    Use elevated context in disassociate_floating_ip

    The call to service_get_by_host_and_topic would raise AdminRequired
    in the case that a non-admin tried to disassociate a floating ip
    from their instance and multi_host was on. Using an elevated
    context for the db lookup enables the host lookup to happend and
    allows a user to disassociate their floating ips.

    Fixes bug 1074437

    Change-Id: I3d47b5a48eae21ea913120bd00728a0b8132da81
    (cherry picked from commit eedd98477dd3b8a5561d30732b7ccf71e9a7d428)

[Clint Byrum (clint-fewbar)]

Hello Brian, or anyone else affected,

Accepted nova into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/nova/2012.2.1+stable-20121212-a99a802e-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package nova - 2012.2.1+stable-20121212-a99a802e-0ubuntu1

---------------
nova (2012.2.1+stable-20121212-a99a802e-0ubuntu1) quantal-proposed; urgency=low

  * Ubuntu updates:
    - debian/control: Ensure novaclient is upgraded with nova,
      require python-keystoneclient >= 1:2.9.0. (LP: #1073289)
    - d/p/avoid_setuptools_git_dependency.patch: Refresh.
  * Dropped patches, applied upstream:
    - debian/patches/CVE-2012-5625.patch: [a99a802]
  * Resynchronize with stable/folsom (b55014ca) (LP: #1085255):
    - [a99a802] create_lvm_image allocates dirty blocks (LP: #1070539)
    - [670b388] RPC exchange name defaults to 'openstack' (LP: #1083944)
    - [3ede373] disassociate_floating_ip with multi_host=True fails
      (LP: #1074437)
    - [22d7c3b] libvirt imagecache should handle shared image storage
      (LP: #1075018)
    - [e787786] Detached and deleted RBD volumes remain associated with insance
      (LP: #1083818)
    - [9265eb0] live_migration missing migrate_data parameter in Hyper-V driver
      (LP: #1066513)
    - [3d99848] use_single_default_gateway does not function correctly
      (LP: #1075859)
    - [65a2d0a] resize does not migrate DHCP host information (LP: #1065440)
    - [102c76b] Nova backup image fails (LP: #1065053)
    - [48a3521] Fix config-file overrides for nova-dhcpbridge
    - [69663ee] Cloudpipe in Folsom: no such option: cnt_vpn_clients
      (LP: #1069573)
    - [6e47cc8] DisassociateAddress can cause Internal Server Error
      (LP: #1080406)
    - [22c3d7b] API calls to dis-associate an auto-assigned floating IP should
      return proper warning (LP: #1061499)
    - [bd11d15] libvirt: if exception raised during volume_detach, volume state
      is inconsistent (LP: #1057756)
    - [dcb59c3] admin can't describe all images in ec2 api (LP: #1070138)
    - [78de622] Incorrect Exception raised during Create server when metadata
      over 255 characters (LP: #1004007)
    - [c313de4] Fixed IP isn't released before updating DHCP host file
      (LP: #1078718)
    - [f4ab42d] Enabling Return Reservation ID with XML create server request
      returns no body (LP: #1061124)
    - [3db2a38] 'BackupCreate' should accept rotation parameter greater than or
      equal to zero (LP: #1071168)
    - [f7e5dde] libvirt reboot sometimes fails to reattach volumes
      (LP: #1073720)
    - [ff776d4] libvirt: detaching volume may fail while terminating other
      instances on the same host concurrently (LP: #1060836)
    - [85a8bc2] Used instance uuid rather than id in remove-fixed-ip
    - [42a85c0] Fix error on invalid delete_on_termination value
    - [6a17579] xenapi migrations fail w/ swap (LP: #1064083)
    - [97649b8] attach-time field for volumes is not updated for detach volume
      (LP: #1056122)
    - [8f6a718] libvirt: rebuild is not using kernel and ramdisk associated with
      the new image (LP: #1060925)
    - [fbe835f] live-migration and volume host assignement (LP: #1066887)
    - [c2a9150] typo prevents volume_tmp_dir flag from working (LP: #1071536)
    - [93efa21] Instances deleted during spawn leak network allocations
      (LP: #1068716)
    - [ebabd02] After restartin...