Horizon allows for ICMP to be type:code.
Type and code can be from -1 to 255.
API refers to both EC2 and Nova APIs
This patch attempts to resolve:
1. API code throws exceptations when 0 is passed for either field
2. API code validates type:code like from->to range. type and code
are independent
3. Update unit tests for this new set of operations.
A side effect is that the following are allowed type:code.
-1:X
X:-1
The code assumes that -1 is a wildcard for the field.
Reviewed: https:/ /review. openstack. org/5449 github. com/openstack/ nova/commit/ c2de5c61b25dccb 6d355640e6c8c9e edd94fdef4
Committed: http://
Submitter: Jenkins
Branch: master
commit c2de5c61b25dccb 6d355640e6c8c9e edd94fdef4
Author: Greg Althaus <email address hidden>
Date: Fri Mar 16 06:41:54 2012 -0700
Tweak security port validation for ICMP
Horizon allows for ICMP to be type:code.
Type and code can be from -1 to 255.
API refers to both EC2 and Nova APIs
This patch attempts to resolve:
1. API code throws exceptations when 0 is passed for either field
2. API code validates type:code like from->to range. type and code
are independent
3. Update unit tests for this new set of operations.
A side effect is that the following are allowed type:code.
-1:X
X:-1
The code assumes that -1 is a wildcard for the field.
bug 956967
Change-Id: Ieb6989815afc69 86b72e0efc7611c 2cc353ab5d8