commit 78c68b84dfc22eec233a607a6b596602487799d7
Author: Adam Gandelman <email address hidden>
Date: Wed Jan 25 12:27:05 2012 -0800
rootwrap: Fix KillFilter matching
The match() method in the KillFilter is a bit buggy. Since most/many
run through this logic in their way to being matched, it creates subtle
issues elsewhere, specifically during linux_net bridge creation. This
fixes two issues.
1. userargs gets elements directly popped off of it. If the KillFilter
does not match the command its checking, the later filter that does is missing
one argument.
2. Type error on pid when checking /proc, this was causing issues on instance
tear down / kill -HUP'ing dnsmasq.
Reviewed: https:/ /review. openstack. org/3429 github. com/openstack/ nova/commit/ 78c68b84dfc22ee c233a607a6b5966 02487799d7
Committed: http://
Submitter: Jenkins
Branch: master
commit 78c68b84dfc22ee c233a607a6b5966 02487799d7
Author: Adam Gandelman <email address hidden>
Date: Wed Jan 25 12:27:05 2012 -0800
rootwrap: Fix KillFilter matching
The match() method in the KillFilter is a bit buggy. Since most/many
run through this logic in their way to being matched, it creates subtle
issues elsewhere, specifically during linux_net bridge creation. This
fixes two issues.
1. userargs gets elements directly popped off of it. If the KillFilter
does not match the command its checking, the later filter that does is missing
one argument.
2. Type error on pid when checking /proc, this was causing issues on instance
tear down / kill -HUP'ing dnsmasq.
Fixes bug 921784
Change-Id: I058ff2276e3154 e8c1f6cc7077fa4 85db60e5827