Comment 2 for bug 921294
Revision history for this message
| Dan Prince (dan-prince) wrote Re: Migration 074 assumes connection_type is defined locally during migrations | #2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Adam,
I'm not entirely happy that we have to rely on flags within the database migrations either... but given that we needed this to pull off the xenapi/libvirt parity changes... explicitly requiring the flag to be set makes sense I think.
If we were to default the connection_type flag to 'libvirt' it may cover the common case but would leave users of XenServer scratching their heads when they try to boot instances (this causes very cryptic errors).
Requiring it to be set explicitly makes this behaviour fail fast which in my opinion makes the most sense. Yes it can be a bit painful but like Vish pointed out above there are a couple different ways to go about it.
Vish: ++ on improving the error message of the exception.