Comment 1 for bug 724623

Revision history for this message
justinsb (justin-fathomdb) wrote :

For anyone curious as to how this snuck through, when I tested it I created the DB model objects in the API layer. I did manual functional testing at that stage. I also created unit tests. However, as part of the review process, it was pointed out that I shouldn't be touching DB objects in the API layer, and so I changed them to simple dictionaries. The tests still passed, but apparently they didn't actually write to the DB, because when this was tried 'for real' it failed, because SQLAlchemy had trouble mapping nested object types (I believe).

In this patch, I've got real testing using the OpenStack API, writing to the DB. It's got a long list of dependencies sadly...