Comment 41 for bug 2004555

Revision history for this message
melanie witt (melwitt) wrote : Re: [ussuri] Wrong volume attachment - volumes overlapping when connected through iscsi on host

I'm attaching a potential patch for nova to use force=True when calling os-brick disconnect_volume() when an instance is being deleted.

Only the libvirt and hyperv drivers are calling os-brick disconnect_volume() that I found, and it's part of the driver.destroy() path.

This change ended up being larger than expected ... I aimed to add basic test coverage for passing the force kwarg through and there are a lot of volume drivers.

If anyone wants something changed or otherwise finds issues in the patch, please let me know.