Use force=True for os-brick disconnect during delete
The 'force' parameter of os-brick's disconnect_volume() method allows
callers to ignore flushing errors and ensure that devices are being
removed from the host.
We should use force=True when we are going to delete an instance to
avoid leaving leftover devices connected to the compute host which
could then potentially be reused to map to volumes to an instance that
should not have access to those volumes.
We can use force=True even when disconnecting a volume that will not be
deleted on termination because os-brick will always attempt to flush
and disconnect gracefully before forcefully removing devices.
Closes-Bug: #2004555
Change-Id: I3629b84d3255a8fe9d8a7cea8c6131d7c40899e8
(cherry picked from commit db455548a12beac1153ce04eca5e728d7b773901)
(cherry picked from commit efb01985db88d6333897018174649b425feaa1b4)
Reviewed: https:/ /review. opendev. org/c/openstack /nova/+ /882860 /opendev. org/openstack/ nova/commit/ 8b4b99149a35663 fc11d7d16308274 7b1b210b4d
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/zed
commit 8b4b99149a35663 fc11d7d16308274 7b1b210b4d
Author: melanie witt <email address hidden>
Date: Wed Feb 15 22:37:40 2023 +0000
Use force=True for os-brick disconnect during delete
The 'force' parameter of os-brick's disconnect_volume() method allows
callers to ignore flushing errors and ensure that devices are being
removed from the host.
We should use force=True when we are going to delete an instance to
avoid leaving leftover devices connected to the compute host which
could then potentially be reused to map to volumes to an instance that
should not have access to those volumes.
We can use force=True even when disconnecting a volume that will not be
deleted on termination because os-brick will always attempt to flush
and disconnect gracefully before forcefully removing devices.
Closes-Bug: #2004555
Change-Id: I3629b84d3255a8 fe9d8a7cea8c613 1d7c40899e8 1153ce04eca5e72 8d7b773901) 33897018174649b 425feaa1b4)
(cherry picked from commit db455548a12beac
(cherry picked from commit efb01985db88d63