OpenStack Compute (nova)

  1. Bug #2004555
  2. Comment #101

Comment 101 for bug 2004555

Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote : Re: [ussuri] Wrong volume attachment - volumes overlapping when connected through iscsi on host

Reviewed the os-brick FC force disconnect support patch. Release note reads well and generates correctly. Code and tests LGTM.

The only thing I noticed was in os_brick/initiator/linuxscsi.py ... this could be a follow up or you could just ignore this comment: in the multipath_del_map() method you added, if mpath isn't deleted until the last iteration of the loop, we won't log the debug message at line 774, which could be misleading when troubleshooting because sometimes on success, we get a log message and sometimes we don't.