OpenStack Compute (nova)

  1. Bug #1996188
  2. Comment #57

Comment 57 for bug 1996188

Revision history for this message
Abhishek Kekane (abhishek-kekane) wrote : Re: Arbitrary file access through custom VMDK flat descriptor

Glance patch attached by Dan looks good to me, just having one suggestion for the error message for below scenario;

+ if not len(allowed):
+ LOG.warning(_('Refusing to process VMDK file as '
+ 'vmdk_allowed_types is empty'))
+ raise RuntimeError(_('Invalid VMDK create-type specified'))

instead we should use something like;

raise RuntimeError(_('Image is a VMDK, but no VMDK createType is allowed'))