Comment 11 for bug 1957939

Revision history for this message
Maximilian Stinsky (mstinsky) wrote :

After thinking a bit about the mentioned patch [1], I think I understand the culprit of this issue.
The patch adds the same function call `self.unplug_vifs(instance, network_info)` twice.
In most setups this result in one call to the function in the new try - except case which unpluggs the vif.
And then we call the same operation a second time which already happend so we are timing out there.
This also explains why I am seeing unexpected vif-unplugg events in nova-compute as it gets events a second time even though it already did the work.
Also furthermore this explains why Will Szumski does not hit the issue when he resizes to the same host as you never get to execute the event two times.

We tested to add a try - expect around the second call to `self.unplug_vifs(instance, network_info)` but seems a bit like a dirty hack aswell.
Maybe someone else knows how to fix this properly.

[1] https://github.com/openstack/nova/commit/66c7f00e1d9d7c0eebe46eb4b24b2b21f7413789#diff-486ddc37ce8e7c105a51566dd2cffbda034f28fae7eaad2e74abf470ab296352