Comment 16 for bug 1939545

Reviewed: https://review.opendev.org/c/openstack/nova/+/843679
Committed: https://opendev.org/openstack/nova/commit/9f7b81c4cfe9f6a41fb28ec3b9d20616817ceab5
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9f7b81c4cfe9f6a41fb28ec3b9d20616817ceab5
Author: Lee Yarwood <email address hidden>
Date: Wed Aug 11 10:51:33 2021 +0100

    Add a regression test for bug 1939545

    Assert the behaviour of the libvirt driver during pre_live_migration
    with instances that have block based volumes attached.

    Bug #1939545 covering the case where the returned path from os-brick
    isn't being saved into the connection_info of the associated bdm in
    Nova.

    The cinder fixture is extended as part of this change to offer
    connection_info listing the iscsi volume type in order to correctly
    assert the behaviour of the associated libvirt volume driver.

    Conflicts: nova/tests/fixtures/cinder.py did not exist, applied
    changes to CinderFixture class in nova/tests/fixtures.py. Also:
    * Switched to using uuidsentinel instead of uuids, as the import is
      done as the former in stable/wallaby.
    * Fixed the fakelibvirt import to match where it lives in
      stable/wallaby.
    * Replace use of OSBrickFixture() that didn't exist in stable/wallaby
      with the fake_os_brick_connector from the libvirt unit tests.
    * Fix fakelibvirt migrateToURI3 monkeypatch to use correct path for
      stable/wallaby.

    Related-Bug: #1939545
    Change-Id: I3f1073d70e4332737e33f3c9c00cf129d0ef76b4
    (cherry picked from commit 268b7169554f871d3813d78e79861934d086484d)