Comment 23 for bug 1917645

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/oslo.messaging/+/828868
Committed: https://opendev.org/openstack/oslo.messaging/commit/d63173a31f500254277641a76bb721a8bf07ad9c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit d63173a31f500254277641a76bb721a8bf07ad9c
Author: Balazs Gibizer <email address hidden>
Date: Wed Nov 24 15:55:35 2021 +0100

    Reproduce bug 1917645

    The [oslo_messaging_notification]retry parameter is not applied during
    connecting to the message bus. But the documentation implies it should[1][2].
    The two possible drivers, rabbit and kafka, behaves differently.

    1) The rabbit driver will retry the connection forever, blocking the caller
       process.

    2) The kafka driver also ignores the retry configuration but the
       notifier call returns immediately even if the notification is not
       (cannot) be delivered.

    This patch adds test cases to show the wrong behavior.

    [1] https://docs.openstack.org/oslo.messaging/latest/configuration/opts.html#oslo_messaging_notifications.retry
    [2] https://github.com/openstack/oslo.messaging/blob/feb72de7b81e3919dedc697f9fb5484a92f85ad8/oslo_messaging/notify/messaging.py#L31-L36

    Related-Bug: #1917645

    Change-Id: Id8557050157aecd3abd75c9114d3fcaecdfc5dc9
    (cherry picked from commit 1db6de63a86812742cbc37a0f5fe1fd7a095dd7f)
    (cherry picked from commit 7390034e479c044d9067d97cd801f9f58c813e41)