Comment 44 for bug 1892361

Reviewed: https://review.opendev.org/c/openstack/nova/+/761824
Committed: https://opendev.org/openstack/nova/commit/1fb4cc03e315f5b4dbebc521f0d1299273c7c396
Submitter: "Zuul (22348)"
Branch: stable/rocky

commit 1fb4cc03e315f5b4dbebc521f0d1299273c7c396
Author: Hemanth Nakkina <email address hidden>
Date: Tue Sep 1 09:36:51 2020 +0530

    Update pci stat pools based on PCI device changes

    At start up of nova-compute service, the PCI stat pools are
    populated based on information in pci_devices table in Nova
    database. The pools are updated only when new device is added
    or removed but not on any device changes like device type.

    If an existing device is configured as SRIOV and nova-compute
    is restarted, the pci_devices table gets updated but the device
    is still listed under the old pool in pci_tracker.stats.pool
    (in-memory object).

    This patch looks for device type updates in existing devices
    and updates the pools accordingly.

    Conflicts:
        nova/tests/functional/libvirt/test_pci_sriov_servers.py
        nova/tests/unit/virt/libvirt/fakelibvirt.py

    The functional test requires to skip the capabilities of pci
    device. This can be done by getting capability template out of
    pci_dev_template [1] which is introduced by commit
    b927748c257e705903c2aa0ffa47b19914e31ede. Not able to clean
    backport the mentioned commit and so removed funtional test
    case.

    [1] https://opendev.org/openstack/nova/src/commit/b0a451d4289dae2086b730fde6b0c7b30f3da2e8/nova/tests/unit/virt/libvirt/fakelibvirt.py#L186

    Change-Id: Id4ebb06e634a612c8be4be6c678d8265e0b99730
    Closes-Bug: #1892361
    (cherry picked from commit b8695de6da56db42b83b9d9d4c330148766644be)
    (cherry picked from commit d8b8a8193b6b8228f6e7d6bde68b5ea6bb53dd8b)
    (cherry picked from commit f58399cf496566e39d11f82a61e0b47900f2eafa)
    (cherry picked from commit 8378785f995dd4bec2a5a20f7bf5946b3075120d)
    (cherry picked from commit 73e631862a81e85fdf9305f3d15b201d780c8743)