Comment 53 for bug 1890501

Revision history for this message
Lee Yarwood (lyarwood) wrote : Re: Soft reboot after live-migration reverts instance to original source domain XML (CVE-2020-17376)

I've now tested the attached patch against stable/rocky and can confirm that it resolves the issue.

One interesting data point with both stable/queens and stable/rocky is that with libvirt v3.6.0 and QEMU 2.11 the instance actually fails to soft reboot due to a locking issue within QEMU as the host block device is already in use by another instance on the host. It then hard reboots recreating the domain working around the issue.

With the patch applied however the initial attempt to soft reboot succeeds as it isn't pointing to the same device as the other instance, thus validating the fix.

I didn't see this on master with Fedora 32, libvirt v6.1.0 and QEMU 4.2.0 so I still think we need to resolve the underlying issue on these older releases for anyone deploying with more modern virt stacks.