Comment 4 for bug 1868464

Reviewed: https://review.opendev.org/714311
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a18dbb5670da0c0b63c4bd69055262b4b7b17e58
Submitter: Zuul
Branch: master

commit a18dbb5670da0c0b63c4bd69055262b4b7b17e58
Author: Marcin Juszkiewicz <email address hidden>
Date: Mon Mar 23 12:07:02 2020 +0100

    libvirt: Change UEFI check to handle AArch64 better

    Nova assumes that images run on UEFI instances will have
    'hw_firmware_type' property set. This is wrong assumption because UEFI
    is the default on AArch64, meaning images do not need to have this set.
    This results in a failure to remove the instance, with libvirt raising
    the following error:

      Instance failed to spawn: libvirt.libvirtError: Requested operation
      is not valid: cannot undefine domain with nvram

    Resolve this by checking *both* the image metadata property and the
    machine arch.

    Change-Id: I2956fe2e3582c36d1c52a7e3becde1dacd9d41f0
    Closes-bug: #1868464