commit d88f353796813bf0ad5ec79ba4714af35e04e591
Author: Matt Riedemann <email address hidden>
Date: Thu Nov 14 14:19:26 2019 -0500
Block deleting compute services with in-progress migrations
This builds on I0bd63b655ad3d3d39af8d15c781ce0a45efc8e3a
which made DELETE /os-services/{service_id} fail with a 409
response if the host has instances on it. This change checks
for in-progress migrations involving the nodes on the host,
either as the source or destination nodes, and returns a 409
error response if any are found.
Failling to do this can lead to orphaned resource providers
in placement and also failing to properly confirm or revert
a pending resize or cold migration.
A release note is included for the (justified) behavior
change in the API. A new microversion should not be required
for this since admins should not have to opt out of broken
behavior.
NOTE(mriedem): The conflict is due to not having change
Iea283322124cb35fc0bc6d25f35548621e8c8c2f in Queens so
_revert_resize is added to ProviderUsageBaseTestCase
within test_servers.py.
Change-Id: I70e06c607045a1c0842f13069e51fef438012a9c
Closes-Bug: #1852610
(cherry picked from commit 92fed026103b47fa2a76ea09204a4ba24c21e191)
(cherry picked from commit a9650b3cbfc674e283964090fb64ac6297be5b78)
(cherry picked from commit a0290858b717b4cefd0d6fc17acc2b143ab12ac4)
(cherry picked from commit 30a635068512be558acf0f9c83185dc1aaad560f)
Reviewed: https:/ /review. opendev. org/699718 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=d88f3537968 13bf0ad5ec79ba4 714af35e04e591
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit d88f353796813bf 0ad5ec79ba4714a f35e04e591
Author: Matt Riedemann <email address hidden>
Date: Thu Nov 14 14:19:26 2019 -0500
Block deleting compute services with in-progress migrations
This builds on I0bd63b655ad3d3 d39af8d15c781ce 0a45efc8e3a {service_ id} fail with a 409
which made DELETE /os-services/
response if the host has instances on it. This change checks
for in-progress migrations involving the nodes on the host,
either as the source or destination nodes, and returns a 409
error response if any are found.
Failling to do this can lead to orphaned resource providers
in placement and also failing to properly confirm or revert
a pending resize or cold migration.
A release note is included for the (justified) behavior
change in the API. A new microversion should not be required
for this since admins should not have to opt out of broken
behavior.
Conflicts:
nova/ tests/functiona l/integrated_ helpers. py
NOTE(mriedem): The conflict is due to not having change 4cb35fc0bc6d25f 35548621e8c8c2f in Queens so seTestCase
Iea28332212
_revert_resize is added to ProviderUsageBa
within test_servers.py.
Change-Id: I70e06c607045a1 c0842f13069e51f ef438012a9c a2a76ea09204a4b a24c21e191) 283964090fb64ac 6297be5b78) efd0d6fc17acc2b 143ab12ac4) 58acf0f9c83185d c1aaad560f)
Closes-Bug: #1852610
(cherry picked from commit 92fed026103b47f
(cherry picked from commit a9650b3cbfc674e
(cherry picked from commit a0290858b717b4c
(cherry picked from commit 30a635068512be5