Comment 5 for bug 1835400

Revision history for this message
sean mooney (sean-k-mooney) wrote :

we discussed this a bit on irc today and honestly i think the osinfo module made several bad assumption not just that the returned value would be valid.

for now i think we should just do the minimal fix for johns issue but

we shoudl consider either droping it entirely or reimplmenting it as it is ignoring the
virt_type, it is assuming the virt_dirver is libvirt eventhough it should be driver indepened since ist in nova.virt not nova.virt.libvirt, it is miss using os_distro, os distro should be centos with os_version set to 7 for centos7 and there are likely other latent issues with it.

so for backport reasons yes we shoudl normalise the valuse but

setting os_distro=centos7.0 is technically missusing that filed.

https://github.com/openstack/glance/blob/90b1f8dc7a2411a7e0286f286d84d8e511d93791/etc/metadefs/operating-system.json#L16-L25

so this feature has been broken since it was added.