libvirt: Stop ignoring unknown libvirtError exceptions during volume attach
Id346bce6e47431988cce7001abcf29a9faf2936a attempted to introduce a
simple breadcrumb in the logs to highlight a known Libvirt issue.
Unfortunately this change resulted in libvirtError exceptions that
didn't match the known issue being silently ignored.
This change corrects this by using excutils.save_and_reraise_exception
to ensure all libvirtError exceptions are logged and raised regardless
of being linked to the known issue.
Change-Id: Ib440f4f2e484312af5f393722363846f6c95b760
Closes-Bug: #1825882
(cherry picked from commit bc57ae50734fa6a70115b6369e867079fb5eb4b8)
(cherry picked from commit b3dedefcc58a1fc76ba37f9f8bb1ef7d238aaceb)
(cherry picked from commit 34b4220448395f10eb2fd39d68b3f527339ab414)
Reviewed: https:/ /review. opendev. org/657050 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=63b45a87b82 655824e61641016 430a6613cee001
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit 63b45a87b826558 24e61641016430a 6613cee001
Author: Lee Yarwood <email address hidden>
Date: Thu Apr 25 14:42:09 2019 +0100
libvirt: Stop ignoring unknown libvirtError exceptions during volume attach
Id346bce6e4 7431988cce7001a bcf29a9faf2936a attempted to introduce a
simple breadcrumb in the logs to highlight a known Libvirt issue.
Unfortunately this change resulted in libvirtError exceptions that
didn't match the known issue being silently ignored.
This change corrects this by using excutils. save_and_ reraise_ exception
to ensure all libvirtError exceptions are logged and raised regardless
of being linked to the known issue.
Change-Id: Ib440f4f2e48431 2af5f3937223638 46f6c95b760 70115b6369e8670 79fb5eb4b8) 76ba37f9f8bb1ef 7d238aaceb) 0eb2fd39d68b3f5 27339ab414)
Closes-Bug: #1825882
(cherry picked from commit bc57ae50734fa6a
(cherry picked from commit b3dedefcc58a1fc
(cherry picked from commit 34b4220448395f1