Change If625411f40be0ba642baeb02950f568f43673655 introduced
nova.utils.get_ksa_adapter, which accepts min_version and max_version
kwargs to be passed through to the ksa Adapter constructor. These are
supposed to represent minimum and maximum *major* API versions,
min_version was erroneously set to *microversions* when setting up the
Adapter for ironicclient. This commit changes it to a major version.
(Microversion negotiation is done within ironicclient itself.)
Also, this bug went latent for several releases because a) it only seems
to be triggered when region_name is given in the conf; but also b)
ironicclient has code to discover a reasonable endpoint if passed None.
So this change also adds a warning log if we try and fail to discover
the endpoint via ksa.
Conflicts:
nova/tests/unit/virt/ironic/test_client_wrapper.py
This was just because the old microversion was 1.37 instead of 1.38. The
patch still changes it to 1.0.
Change-Id: I34a3f8d4a496217eb01790e2d124111625bf5f85
Closes-Bug: #1825583
(cherry picked from commit 13278be9f265e237fc68ee60acfacaa1df68522e)
(cherry picked from commit 35bda4ec385e4c2b3d4cee07467f5077b13b1dd9)
Reviewed: https:/ /review. opendev. org/656523 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=ba3ad2d65af 20332e768a6df0e 2c2d64292f9e2c
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit ba3ad2d65af2033 2e768a6df0e2c2d 64292f9e2c
Author: Eric Fried <email address hidden>
Date: Fri Apr 19 15:35:21 2019 -0500
Fix {min|max}_version in ironic Adapter setup
Change If625411f40be0b a642baeb02950f5 68f43673655 introduced utils.get_ ksa_adapter, which accepts min_version and max_version
nova.
kwargs to be passed through to the ksa Adapter constructor. These are
supposed to represent minimum and maximum *major* API versions,
min_version was erroneously set to *microversions* when setting up the
Adapter for ironicclient. This commit changes it to a major version.
(Microversion negotiation is done within ironicclient itself.)
Also, this bug went latent for several releases because a) it only seems
to be triggered when region_name is given in the conf; but also b)
ironicclient has code to discover a reasonable endpoint if passed None.
So this change also adds a warning log if we try and fail to discover
the endpoint via ksa.
Conflicts: tests/unit/ virt/ironic/ test_client_ wrapper. py
nova/
This was just because the old microversion was 1.37 instead of 1.38. The
patch still changes it to 1.0.
Change-Id: I34a3f8d4a49621 7eb01790e2d1241 11625bf5f85 7fc68ee60acfaca a1df68522e) b3d4cee07467f50 77b13b1dd9)
Closes-Bug: #1825583
(cherry picked from commit 13278be9f265e23
(cherry picked from commit 35bda4ec385e4c2