get_instance_diagnostics expected all interfaces
to have a <target> element with a "dev" attribute in
the instance XML. This is not the case for VFIO
interfaces (<interface type="hostdev">).
This caused an IndexError when looping over
the interfaces.
This patch fixes this issue by retrieving interfaces
data directly from the guest XML and adding nics
appropriately to the diagnostics object.
Change-Id: I8ef852d449e9e637d45e4ac92ffc5d1abd8d31c5
Closes-Bug: #1821798
(cherry picked from commit ab7c968b6f66404c032f62a952e353f94d3be165)
Reviewed: https:/ /review. opendev. org/657125 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=1d4f64b190a fc60b0c2a56de71 8209869c41cfb3
Committed: https:/
Submitter: Zuul
Branch: stable/stein
commit 1d4f64b190afc60 b0c2a56de718209 869c41cfb3
Author: Francois Palin <email address hidden>
Date: Tue Mar 26 15:22:40 2019 -0400
Include all network devices in nova diagnostics
get_ instance_ diagnostics expected all interfaces
to have a <target> element with a "dev" attribute in
the instance XML. This is not the case for VFIO
interfaces (<interface type="hostdev">).
This caused an IndexError when looping over
the interfaces.
This patch fixes this issue by retrieving interfaces
data directly from the guest XML and adding nics
appropriately to the diagnostics object.
Change-Id: I8ef852d449e9e6 37d45e4ac92ffc5 d1abd8d31c5 c032f62a952e353 f94d3be165)
Closes-Bug: #1821798
(cherry picked from commit ab7c968b6f66404